Skip to content

Enable setting client certificate parent #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2021
Merged

Enable setting client certificate parent #44

merged 2 commits into from
Apr 7, 2021

Conversation

torntrousers
Copy link
Contributor

This is similar to #39 in that it enables setting the parent certificate of a client certificate, but the difference to #39 is that it works when the client certificate private key is using an ECC508/608 key slot.

This change is based from #43 and with these two changes it makes it possible to use AWS JITP with an Arduino Nano 33 IoT with the private key stored in the ATECC608A.

@github-actions
Copy link

Memory usage change @ 96cba2d

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 💚 -96 - 0 -0.04 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 💚 -88 - 0 -0.03 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SHA1
flash		 % examples/SHA1
RAM for global variables		 % examples/SHA256
flash		 % examples/SHA256
RAM for global variables		 % examples/WiFiSSLClient
flash		 % examples/WiFiSSLClient
RAM for global variables		 % examples/MKRGSMSSLClient
flash		 % examples/MKRGSMSSLClient
RAM for global variables		 %
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 -96 -0.04 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 -88 -0.03 0 0.0
Click for full report CSV 
Board,examples/SHA1<br>flash,%,examples/SHA1<br>RAM for global variables,%,examples/SHA256<br>flash,%,examples/SHA256<br>RAM for global variables,%,examples/WiFiSSLClient<br>flash,%,examples/WiFiSSLClient<br>RAM for global variables,%,examples/MKRGSMSSLClient<br>flash,%,examples/MKRGSMSSLClient<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,-96,-0.04,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,,,,,-88,-0.03,0,0.0

@aentinger
Copy link
Contributor

@ffontaine what do you think?

@ffontaine
Copy link
Contributor

It'm ok with the changes made in this PR.

aentinger
aentinger approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @torntrousers 🚀

@aentinger aentinger merged commit e985450 into arduino-libraries:master Apr 7, 2021
@torntrousers
Copy link
Contributor Author

Thats great, thank you. Any chance of a new release?

@aentinger
Copy link
Contributor

I'd like to wait the outcome of #45 and afterwards I'd to a new release.

@aentinger
Copy link
Contributor

@torntrousers here you've got it: https://github.com/arduino-libraries/ArduinoBearSSL/releases/tag/1.7.0

@torntrousers
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torntrousers @aentinger @ffontaine